-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python first-class providers #350
Conversation
Adds support for referring to the Kubernetes provider in a first-class manner in Python. This is accomplished using a similar method to Node - the provider is explicitly projected as a resource and users are free to instantiate it at-will and use it to create other Kubernetes resources. This commit also adds a smoke test for the feature.
I haven't hooked up the test to the test harness yet - I suspect that it'll fail since it requires a new release of |
@swgillespie you seem to be correct about the failure, what do we need to get this up and running? Wait for a release? (I know embarrassingly ~nothing about pip.) |
On Friday we shipped a release of the |
1. Fix the minimum version of the pulumi package to 0.16.10, the minimum for first-class providers 2. Hook up the smoke test to the integration test framework 3. Update the referenced version of pulumi in the provider test's requirements.txt
Looks like the istio test failed?
|
|
nice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know much about pulumi.ProviderResource
, so this approval comes with a grain of salt. :)
@swgillespie re-ran your tests, this is a Python-related error: https://travis-ci.com/pulumi/pulumi-kubernetes/builds/97289084#L8441 |
I'm not sure what the deal is with the Python issue, but it didn't repro when I re-ran the tests again... most likely something went wrong here during the installation step, since the crash isn't in our code at all. Is this ok to merge? |
Adds support for referring to the Kubernetes provider in a first-class
manner in Python. This is accomplished using a similar method to Node -
the provider is explicitly projected as a resource and users are free to
instantiate it at-will and use it to create other Kubernetes resources.
This commit also adds a smoke test for the feature.
(Finally) fixes pulumi/pulumi#1713.